[PR #1093/c9784148 backport][stable-3] iam_policy - update examples, add RETURN, add required_if case #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
iam_policy - update examples, add RETURN, add required_if case SUMMARY fix broken example add RETURN documentation require one of policy_document or policy_json when state is present add extra integration tests for check mode idempotency cases ISSUE TYPE Bugfix Pull Request COMPONENT NAME iam_policy Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <[email protected]> (cherry picked from commit c978414)
ansibullbot
added
bug
markuman
approved these changes
May 5, 2022
|
regate |
|
Depends-On: #1123 |
|
regate |
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-3/c97841482bff44038ae357d625cc27a11c8efed0/pr-1093
branch
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…ions#1097) inventory/aws_ec2: deprecate include_extra_api_calls The include_extra_api_calls option of the inventory plugin is broken and actually crashes the plugin with a list index out of range error. It assumes describe_instance_status always returns a list with one entry which is not the case if the instance is stopped. In addition, it reads the event from for a Events key that doesn't exist in the answer structure. https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ec2.html#EC2.Client.describe_instance_status The feature is not covered by any tests in our CI and obviously, nobody uses it. Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1093 as merged into main (c978414).
SUMMARY
ISSUE TYPE
COMPONENT NAME
iam_policy